Comments on the colab notebook

[leix28]

• Orion version: Commit 23f2bcc
• Python version: 3.6
• Operating System: Google Colab

Description

I tried to use the colab notebook. I think it's nice and clear. Here are a few comments to make it better.

• pipeline='tadgan.json' I learned from the source code that pipeline actually supports json, MLPipeline and dict. I think it may make sense to use the dict version to make the everything in the same colab. Further more, it would be nice to have more comments in the config json to show different options for each hyperparamter. (json does not support comments. hjson is a good alternative.)
• I was not clear how to reduce the number of epochs until I found the tadgan.json and edit it. I think maybe I can change it via the hyperparameter arg for Orion. But I'm still not sure how to do it.
• Consider add legend to figures (green for ground truth and red for prediction).
• Consider zoom in plot_ts. (Or even make it interactive.)
• The fitting log shows that the discriminator and generator lasses are a vector. I don't understand what that means.