aem-react icon indicating copy to clipboard operation
aem-react copied to clipboard

Performance on 0.22

Open sovanyio opened this issue 7 years ago • 2 comments
trafficstars

Have another one for you :) https://github.com/sovanyio/aem-react/tree/compile-at-start

On the older branch of 0.4.2, we were running into server lag issues that seem to have stemmed from not setting the maxIdle setting on the ObjectPool, leading to object churn. In debugging that, we figured that warming all objects in the pool at start would be best for performance. With the pool set at 30 I'm seeing around 1m30s-2m warming runs with performant renders after that and no random server lagging due to object churn.

I also went ahead and moved the created engine log to a debug message and logged exceptions out directly from the library. Also added support for writing exceptions to the page if the param debug is set in the request url.

Let me know what you think, I'll create a PR if you think its good.

sovanyio avatar Feb 08 '18 20:02 sovanyio

Updated with some of your comments: https://github.com/sinnerschrader/aem-react/compare/next...sovanyio:compile-at-start?expand=1

sovanyio avatar Feb 12 '18 21:02 sovanyio

Looks good to me.

stemey avatar Feb 19 '18 08:02 stemey