Colin Douch
Colin Douch
Actually, looking at it a bit more: configgrpc provides `.Serve(net.Listener)`, and all the uses in the contrib repo _actually_ use `confighttp`s `ToListener` to create the listener to pass into that,...
Apologies 😬 I think I've fixed it up now anyway
Oh hrm.. I checked several, like https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/skywalkingreceiver/skywalking_receiver.go#L144 , but you're right - missed the ones that use confignet. Want me to update that here? Or put in a seperate PR?
Done. Is there anything blocking this PR then? I see the CodeCov, but those lines _are_ covered, just in the windows tests (which tracks the error flow)
Done @axw @bogdandrutu is this ok now?
Test failure looks unrelated to this?
@dmathieu @bogdandrutu Can this go now?
Test failures are all the same - https://github.com/open-telemetry/opentelemetry-collector/commit/73f090cd0d59a3faa237168750d44a0036d8fd5c broke it ``` Error: ../../internal/aws/ecsutil/client.go:65:46: cannot use host (variable of interface type component.Host) as map[component.ID]component.Component value in argument to clientSettings.ToClient ```
I have a patch internally already, so I can PR that tomorrow. If it doesn't work with your expected changes @akats7 then I'm happy to abandon it in favor of...
Hey - apologies, been a bit busy. I think it's best to go with your stuff here. My internal patch is proving weirdly buggy for reasons I can't seem to...