cesiumpy icon indicating copy to clipboard operation
cesiumpy copied to clipboard

URL Updates and Google Warning

Open cksammons7 opened this issue 4 years ago • 1 comments

Hello!

I've been wanting to use the cesiumpy package, but have had problems similar to the 'Issues'. Following the cesiumjs tutorial, I made some changes to the cesiumpy code and after these changes, the package now successfully works. As mentioned in the git commits, I updated the URLs, the divid, and the geocoder.

When I ran the package the first time, there would be a Google warning. So I changed the geocoder to one that did not require a Key API for the map. I thought this would fix the issue, but still nothing would happen after running the code. I then looked at the html cesiumpy produces, and noticed differences compared to the html from the cesiumjs tutorial. So I made additional changes to match the html code.

I'm new to GitHub and coding, so I wasn't sure what to include in this but hopefully it covers what I updated. Any pointers for the future would be greatly appreciated.

Thank you!

cksammons7 avatar Apr 20 '20 17:04 cksammons7

Hello @cksammons7! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 105:80: E501 line too long (117 > 79 characters) Line 106:80: E501 line too long (135 > 79 characters)

pep8speaks avatar Apr 20 '20 17:04 pep8speaks