Ashish Kumar Sinha

Results 56 comments of Ashish Kumar Sinha

@elias-dbx the comment for `InclusiveLabel` is : ``` /// Includes resources with the same $label or $label:$value eg: /// if label is "Zone: A": /// A resource with "Zone: A"...

> Hi @sinhaashish . Looking at the code ExclusiveLabel does appear to do what we want to do for spreading volumes across topology (or 'Zones' as they are called in...

Hi @elias-dbx We have discussed the approach and finalised the below. The Storage class will have `nodeTopologyAffinity`, `nodeTopologySpread` and `nodeInclusion` , This will decide the node topology. For pool we...

hi @ianb-mp As @w3aman said you can use this doc https://github.com/openebs/zfs-localpv/blob/develop/docs/faq.md#6-how-to-add-custom-topology-key to add the custom label. As i can understand in your case the kubervirt has dynamic label which changes...

IMHO using a flag to skip the validation will be musch simpler change to do , rather than refactoring

> Test is failing because it's waiting for `CStorPoolCluster` That bit should be removed, including any cstor code. The installation itself is installing cstor https://raw.githubusercontent.com/openebs/openebs/v3.10.0/k8s/openebs-operator.yaml and there is a lot...

There is an issue in labelling the nodes. The nodes doesn't get labelled if the label has `/` in it. Now since the nodes are not labelled `nodeSpreadTopologyKey` doesn't work...

Closing this as user hasn't replied.

I have removed affinity from the `LabelledTopology`. Its just that once the volume is created the inclusion will show the key value, and value will be created at the run...

@tiagolobocastro @Abhinandan-Purkait PTAL , not merging it until re approved