singularityware
about: correct references to runc
It appears this document was drafted some time before runc gained support for rootless containers. dfba702 ("adding fork me on github, page on environment metadata, and making tons of changes for 2.3!") removed some other out-dated information but this section remained.
Signed-off-by: Aleksa Sarai [email protected]
It's also quite frustrating that this document doesn't mention bubblewrap nor LXC. Both of these have had support for rootless containers longer than runc.
hey @cyphar! I'll be sure to set some time to review this soon, it's really great to have your contribution. Definitely add add more on LXC and bubble wrap if you would like! It might be very useful learning for our users.
There are a few modifications to your wording that I would like to make to articulate the usage delta between HPC and enterprise and applicability for our use-cases, but we are happy to fix the wording as no ill-intent was intended.
Thanks for the PR!
hey @gmkurtzer and @cyphar this is great discussion! For a quick update from me (and ETA for you) we are doing some re-organization of the docs first for 2.4, and when we finish that up we will better be able to work on the changes here (i.e., with some file renaming it will be messy if do it the other way around.) So stay tuned! :)
You are amazing @vsoch! I'm starting to go through it, and it looks fantastic!
I've pushed an updated paragraph, but sure I can wait until you make the changes for 2.4. Sorry again for the over-reaction. Thanks!
hey it's ok, this kind of thing has happened to me too :) It just means that you care a lot about what you do, and really that's a good thing. In the end, I think all parties (and documentation involved) will be the better for the experience.
We will get them consolidated likely later today, stay tuned!
quick update - we merged in (major) changes to the structure, and @GodloveD is going to do some final work and additions. The release is planned tentatively for tomorrow PM, so @gmkurtzer and @cyphar let's review the content here before that so it goes out with the new docs.
check out the docs/2.4 branch: https://github.com/singularityware/singularityware.github.io/tree/docs/2.4 We will merge into master when 2.4 is released, and then docs/2.4 will be more of an archive so down the line when we need to know, we can correspond with the various versions.
I am fixing some things too in my branch. It might be better just to wait until we are done, and then take a look @cyphar (that way we don't waste your time looking at it before we are done).
Thanks!
hey @cyphar apologies I didn't ping you when we finished up the docs! They are online (current master and on the main site) if you want to take a look - likely we have some tweaks to do, but if you'd like to contribute some about runc it would be appreciated.