singularity-compose icon indicating copy to clipboard operation
singularity-compose copied to clipboard

adding support for custom network args

Open vsoch opened this issue 2 years ago • 1 comments

This will close #60 @scicco you can follow the example here: https://github.com/singularityhub/singularity-compose-examples/tree/master/v2.0/custom-network

I think part of the trouble was the entrypoint had an envar, evaluated from the host is not going to work, so I added a startscript instead. So this PR is adding support for custom network args primarily.

Give that a shot, show me what doesn't work (and I'll fix it up) and we can go from there!

Signed-off-by: vsoch [email protected]

vsoch avatar Aug 24 '22 23:08 vsoch

First of all thank you for the PR 😄

I've checked the example and I have some doubts. I'll try to illustrate them by commenting on your changes.

scicco avatar Aug 25 '22 07:08 scicco