singularity icon indicating copy to clipboard operation
singularity copied to clipboard

Save complete

Open sproul21 opened this issue 2 years ago • 1 comments

sproul21 avatar Apr 11 '23 15:04 sproul21

this PR is problematic, it adds megabytes of binary music files into the repo and changes lots of code; each code change/feature should be made into a separate PR so it can be properly reviewed.

rofl0r avatar May 04 '23 14:05 rofl0r

I am not sure what to make of this PR. As already implied above, it is hard to review in its current form, so I will close it.

Note that some of the features from the PR is now implemented in singularity partly or fully.

  • Quick saves (via F5 for save + F9 for load), though it uses a separate save name.
  • Auto save (once per 3 days and only one save, rather than once per day with a unique save per day).
  • The theme changes were not adopted but there are now separate theme settings for the knowledge/research pane, so those can be changed via a theme without code changes now.

Other things were left as-is (such as Music is still kept deliberately in a separate repo)

nthykier avatar Jun 14 '24 19:06 nthykier