Singular-SKAdNetwork-App icon indicating copy to clipboard operation
Singular-SKAdNetwork-App copied to clipboard

Used curve is incorrect

Open dynamix opened this issue 4 years ago • 5 comments

The example uses p256 but Apple requires p192.

dynamix avatar Jul 31 '20 10:07 dynamix

Confirmed https://developer.apple.com/documentation/storekit/skadnetwork/registering_an_ad_network

However, it looks like they changed the docs.

egorlitvinenko avatar Jul 31 '20 10:07 egorlitvinenko

They did, which is annoying because the key we submitted in the beginning used secp256r1. The choice of prime192v1 is questionable and I wrote them about it (nobody uses it, not all libs support it, it is considered not very secure, more hash digest than bits in the curve ...)

dynamix avatar Jul 31 '20 13:07 dynamix

thanks @dynamix - yep, we also suspect this changed... we are updating the repo to use prime192v1 - thx!

danielxt7 avatar Jul 31 '20 17:07 danielxt7

that guidance has changed once again to prime256v1

old: http://web.archive.org/web/20200920102544if_/https://developer.apple.com/documentation/storekit/skadnetwork/registering_an_ad_network new: https://developer.apple.com/documentation/storekit/skadnetwork/registering_an_ad_network

bzarzoza avatar Oct 22 '20 19:10 bzarzoza

change to p192 plus a note in readme to highlight necessary equality in keypair and adserver -> addressed with #10

fmaschmeier avatar Nov 18 '20 09:11 fmaschmeier