snet-daemon icon indicating copy to clipboard operation
snet-daemon copied to clipboard

private key log message is confusing/concerning

Open ferrouswheel opened this issue 5 years ago • 1 comments

Daemon reports config to logging, and I think it correctly hides the private key, but it shows this instead:

time="2019-07-11T03:04:21.249017873Z" level=info msg="private_key: "

This is unable to be differentiated from an empty string, which I assume is an error?

So if it is hiding the key, it should probably replace it with something like ***** in the log message.

ferrouswheel avatar Jul 11 '19 03:07 ferrouswheel

@ferrouswheel , will remove the references to private key in deamon ( all the claims are now done at snet-cli) and Daemon does not do any more write operations on block chain

anandrgitnirman avatar Jul 12 '19 13:07 anandrgitnirman