platform-contracts icon indicating copy to clipboard operation
platform-contracts copied to clipboard

Automate publishing development versions of the package

Open vsbogd opened this issue 6 years ago • 6 comments

This issue is result of discussion in PR https://github.com/singnet/platform-contracts/pull/51 (see PR https://github.com/singnet/snet-cli/pull/76 for previous related change).

Solution proposed in PR https://github.com/singnet/platform-contracts/pull/51 requires additional compilation and package building when platform-contracts package is deployed as dependency.

Solution proposed in PR https://github.com/singnet/snet-cli/pull/76 requires developing dev dependency installation script and .circleci scenarios modification for each repo which uses platform-contracts.

So we need to design and develop packaging solution which doesn't have these disadvantages or agree with one of the approaches above.

vsbogd avatar Oct 15 '18 10:10 vsbogd

One possible way is to publish new github release each time when we need new version globally.

It can be published manually for instance using some script. Or we can add publishing step to the circleci script which handlea changes in master branch. The only problem I see is authentication.

vsbogd avatar Oct 16 '18 17:10 vsbogd

I have added first development release for platform-contracts manuall release v0.2.2

Commands to create release tarball:

VERSION=0.2.2
npm install
npm run compile
npm run package-npm
cd build
mv npm-module singularitynet-platform-contracts
tar czf singularitynet-platform-contracts-${VERSION}.tgz singularitynet-platform-contracts

vsbogd avatar Oct 17 '18 13:10 vsbogd

Should we close it?

astroseger avatar Oct 23 '18 14:10 astroseger

I would say we should automate release publishing first then we can close it.

vsbogd avatar Oct 23 '18 14:10 vsbogd

Now snet-cli and daemon use development releases in order to get ABI of contracts. But it should be noted that snet-cli gets address of Registry and AgentFactory from networks/*.json files from npm-package. Which is might be not optimal for tests...

astroseger avatar Oct 26 '18 12:10 astroseger

We can remove all network addresses except main and testnet from published versions.

vsbogd avatar Oct 26 '18 12:10 vsbogd