single-spa-vue icon indicating copy to clipboard operation
single-spa-vue copied to clipboard

Published 20 hours ago • verified publisher icon single-spa

Fix types for props

Open Lalaluka opened this issue 3 years ago • 6 comments

I finally came around working on #86 was a bit more than you proposed @joeldenning but now it should work.

Tests are passing and I also installed the renewed package in a Vue2 and Vue3 Application and it still works.

(I also updated the single-spa version)

Lalaluka avatar Nov 29 '21 16:11 Lalaluka

Can you please review this PR. We need this patch.

kosmos avatar Dec 16 '21 14:12 kosmos

This fix really important for us too, it allow us to use typescript in applications. review please.

rkovinko avatar Dec 23 '21 09:12 rkovinko

Same for us. Could you please review it and merge as soon as possible? Thanks!

Dmitriyes7 avatar Dec 23 '21 09:12 Dmitriyes7

Guys, please, review this PR.

SmartXXI avatar Dec 24 '21 13:12 SmartXXI

Hi, @Lalaluka I've tested your solution locally and it looks like issue still present when I try to pass any other custom props. render?: (this: AppProps) => any; in this line we define "this" as AppProps and error is next: 'customProp' does not exist on type 'AppProps'

svyatoslav-e avatar Feb 22 '22 18:02 svyatoslav-e

Is this still a problem? The code looks fine, but @svyatoslav-e's comment makes me unsure that it fully fixes the problem

joeldenning avatar Jun 29 '23 19:06 joeldenning