create-single-spa icon indicating copy to clipboard operation
create-single-spa copied to clipboard

Upgrade babel loader into esbuild loader

Open bfoong-equinix opened this issue 1 year ago • 5 comments

Upgraded webpack's babel-loader into esbuild-loader to improve transpilation speed

Performance gain reference https://github.com/esbuild-kit/esbuild-loader/discussions/138

bfoong-equinix avatar Mar 29 '23 11:03 bfoong-equinix

🦋 Changeset detected

Latest commit: 42c0417869ffef2ac5eaa079ec77d32c8952128e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
webpack-config-single-spa Patch
webpack-config-single-spa-react Patch
webpack-config-single-spa-ts Patch
webpack-config-single-spa-react-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Mar 29 '23 11:03 changeset-bot[bot]

@joeldenning noticed you mentioned in another PR you are not actively maintaining anymore, which maintainer should we ping to get a review?

bfoong-equinix avatar Apr 04 '23 06:04 bfoong-equinix

Looking through other closed PR's, I think @TheMcMurder might be the guy

gregorysl avatar Jun 21 '23 15:06 gregorysl

thanks @gregorysl. @TheMcMurder are you able to review this PR?

bfoong-equinix avatar Jun 22 '23 07:06 bfoong-equinix

Hi, this PR would require more work, specifically taking into account caveats mentioned in the esbuild-loader documentation:

Caveats esbuild only supports a subset of tsconfig options (see TransformOptions interface).

Enable isolatedModules to avoid mis-compilation with features like re-exporting types.

Enable esModuleInterop to make TypeScript's type system compatible with ESM imports.

Features that require type interpretation, such as emitDecoratorMetadata and declaration, are not supported.

→ Read more about TypeScript Caveats

I would recommend starting a discussion in the Slack's maintainers channel so we can discuss the implications.

MilanKovacic avatar Sep 28 '23 00:09 MilanKovacic