create-single-spa icon indicating copy to clipboard operation
create-single-spa copied to clipboard

fix: use @typescript-eslint/parser when react typescript

Open pmjhonwang opened this issue 2 years ago • 3 comments

maybe should I support both @babel/eslint-parser and @typescript-eslint/parser via eslint overrides?

pmjhonwang avatar Mar 02 '22 20:03 pmjhonwang

🦋 Changeset detected

Latest commit: 058abb1e32308584491c53b8643a74869164a0b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
generator-single-spa Patch
create-single-spa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Mar 02 '22 20:03 changeset-bot[bot]

Hi @pmjhonwang I'd like to circle back to this. Do you think these changes are still valid today? Or any updates to make before merging? Thanks again for your contribution!

filoxo avatar Apr 30 '22 17:04 filoxo

Hi @pmjhonwang I'd like to circle back to this. Do you think these changes are still valid today? Or any updates to make before merging? Thanks again for your contribution!

thx for CR

pmjhonwang avatar May 11 '22 09:05 pmjhonwang