Sergio Garcia

Results 42 comments of Sergio Garcia

Closed this accidentally when managing my own fork

I don't understant the CI error at all. Apparently they changed the default output of argparse? But somehow our test suite is getting both, and fails no matter which one...

Otherwise this is ready for merge, I want to make more changes but this PR is already very big, so it's probably best to keep it simple

Closing this for now, will continue after the rebase

Rebasing the style changes from #5785 TBD if there's interest in merging this. As discussed with @ktf, it brings a behaviour change that might be more technically correct, but currently...

I toggled FullCI as no longer required, and will delete it soon. Not sure where the Aligenerators error is coming from, is GNU Gengetopt a dependency on our builder? And...

> > @singiamtel can we cache this PR and then merge it? Thanks. > > @ktf @singiamtel : I would recommend we do this together with bumping CMake: #5792 Both...

Cache run ongoing @ https://alijenkins.cern.ch/job/CacheO2Package/113/

As discussed, I merged both #5661 and #5792 in this PR, and rebased so we have the right commits for each. New cache run is ongoing in https://alijenkins.cern.ch/job/CacheO2Package/114/

The cache build is done. This tests should be running against exactly the same code as before, I think it should be fine to merge