flutter-quill icon indicating copy to clipboard operation
flutter-quill copied to clipboard

Fixes flutter 3.32 macos crash

Open theniceboy opened this issue 6 months ago โ€ข 2 comments

Description

Flutter issue: https://github.com/flutter/flutter/issues/169204

Related Issues

Fixes #2572 Fixes #2575

Type of Change

  • [ ] โœจ Feature: New functionality without breaking existing features.
  • [x] ๐Ÿ› ๏ธ Bug fix: Resolves an issue without altering current behavior.
  • [ ] ๐Ÿงน Refactor: Code reorganization, no behavior change.
  • [ ] โŒ Breaking: Alters existing functionality and requires updates.
  • [ ] ๐Ÿงช Tests: New or modified tests
  • [ ] ๐Ÿ“ Documentation: Updates or additions to documentation.
  • [ ] ๐Ÿ—‘๏ธ Chore: Routine tasks, or maintenance.
  • [ ] โœ… Build configuration change: Build/configuration changes.

theniceboy avatar May 26 '25 07:05 theniceboy

FYI, this fixes the bug on Windows as well.

idispatch75 avatar May 26 '25 14:05 idispatch75

The bug reported in the flutter repo also mentions that didChangeDependencies() should be handled. It might apply here, but is not handled in this PR.

idispatch75 avatar May 26 '25 15:05 idispatch75

@singerdmx Can we get this merged please?

ppamorim avatar Jun 04 '25 09:06 ppamorim

@theniceboy rebase with the latest master may fix the test error. I'm looking for this too.

theachoem avatar Jun 15 '25 20:06 theachoem

@singerdmx Can we get this merged please?

Please ๐Ÿ™

rodolfogoulart avatar Jun 24 '25 16:06 rodolfogoulart

@singerdmx Can we get this merged please?

Please ๐Ÿ™

Another vote for merging this change in. Can't use Quill on macOS at all without this fix. Crashes as soon as you try to use the editor ... Tried on both Flutter 3.32.2 and 3.32.5 and the same results. Once I manually added the fix, no more crashes.

FahimF avatar Jul 01 '25 00:07 FahimF

Quill is totally broken on Flutter 3.32.6 ๐Ÿ˜ข

sort72 avatar Jul 14 '25 23:07 sort72

please merge.

alinri avatar Jul 16 '25 15:07 alinri

I will merge it soon.

EchoEllet avatar Jul 21 '25 23:07 EchoEllet

The failing test added in https://github.com/singerdmx/flutter-quill/pull/2616 now passes after merging this PR.

EchoEllet avatar Jul 22 '25 01:07 EchoEllet