flutter-quill icon indicating copy to clipboard operation
flutter-quill copied to clipboard

chore: move members of magnifier feature into a separate files when possible (not final yet)

Open EchoEllet opened this issue 1 year ago โ€ข 1 comments

Description

Cleanup #2026 by extracting the new methods, members, and checks to separate files when possible

Not for merge yet, I'm uncertain about some of the changes made, waiting response from the contributor, also the new TODOs introduced in this PR need to be cleaned up before merging.

This PR does separate anything related to the magnifier feature in one manageable place in a simple way. Still need more improvements.

Even after the cleanup, the new code is still not qualified enough as I'm unable to understand some of the changes made. There might be inconsistency issues.

Related Issues

  • Related #2026
  • Related #2049
  • Related #2111
  • Related #2116
  • Related #2124

Type of Change

  • [ ] โœจ New feature: Adds new functionality without breaking existing features.
  • [ ] ๐Ÿ› ๏ธ Bug fix: Resolves an issue without altering current behavior.
  • [x] ๐Ÿงน Code refactor: Code restructuring that does not affect behavior.
  • [ ] โŒ Breaking change: Alters existing functionality and requires updates.
  • [ ] ๐Ÿงช Tests: Adds new tests or modifies existing tests.
  • [ ] ๐Ÿ“ Documentation: Updates or additions to documentation.
  • [x] ๐Ÿ—‘๏ธ Chore: Routine tasks, or maintenance.
  • [ ] โœ… Build configuration change: Changes to build or deploy processes.

EchoEllet avatar Sep 19 '24 22:09 EchoEllet

Haven't tested the changes yet.

EchoEllet avatar Sep 19 '24 23:09 EchoEllet

I have extracted some parts of this PR into release/v11. Closing this PR as I don't see it as a good time investment.

EchoEllet avatar Oct 27 '24 13:10 EchoEllet