flutter-quill icon indicating copy to clipboard operation
flutter-quill copied to clipboard

Paste context menu not dismissed

Open AtlasAutocode opened this issue 1 year ago • 8 comments

Is there an existing issue for this?

Flutter Quill version

10.4.4

Steps to reproduce

Use the example app and run on mobile. Long press to select a word, get popup menu and select Copy. Popup menu is dismissed. Long press at a different place, get popup menu and select Paste. Text is pasted but the popup menu is NOT dismissed.

This issue was fixed in PR2116 These changes were removed in PR2128 to address the problem with the magnifier.

Expected results

Popup menu should be dismissed after paste is selected.

Actual results

Popup menu is still present after paste is selected.

Code sample

Code sample
[Paste your code here]

Additional Context

Screenshots / Video demonstration

[Upload media here]

Logs
[Paste your logs here]

AtlasAutocode avatar Aug 26 '24 22:08 AtlasAutocode

@demoYang and @CatHood0 can you take a look at this problem? These changes appear to be mutually exclusive. I regret that I do not understand mobile enough to be able to figure out what is going on.

AtlasAutocode avatar Aug 26 '24 22:08 AtlasAutocode

I know what part is causing the error. I'll test my fix soon (i don't know why it was removed)

CatHood0 avatar Aug 26 '24 22:08 CatHood0

@CatHood0 your changes fixed the paste problem. I assume @demoYang made the changes because it was needed to fix the problem with the magnifier.

However, when I re-introduced your changes, it caused even more problems. So, I think there is some deeper conflict between paste popup and magnifier.

AtlasAutocode avatar Aug 27 '24 00:08 AtlasAutocode

However, when I re-introduced your changes, it caused even more problems.

I don't expect that. It's weird. You have a point, it could be something more deeper than we expect.

CatHood0 avatar Aug 27 '24 01:08 CatHood0

Does this issue still persists? If not we need to close it.

CatHood0 avatar Sep 21 '24 03:09 CatHood0

@AtlasAutocode

Is this still an issue?

EchoEllet avatar Sep 21 '24 13:09 EchoEllet

Yes, still exists. I haven't had time to look into it since I almost never use mobile and know nothing about how such popups are managed. It's an obvious bug but not critical. Feel free to close this issue.

AtlasAutocode avatar Sep 21 '24 13:09 AtlasAutocode

Will keep it open, since we don't add new features anymore, we should have more time but for now, we're focusing on other issues.

EchoEllet avatar Sep 21 '24 14:09 EchoEllet

This issue should be fixed in version 11.0.0-dev.20. @AtlasAutocode Could you confirm if this version fixed the encountered issue?

EchoEllet avatar Jan 19 '25 04:01 EchoEllet