singerdmx
Unnecessary scroll to the cursor when checking/unchecking a checkbox
Is there an existing issue for this?
- [X] I have searched the existing issues
Flutter Quill version
master
Steps to reproduce
- Place the cursor somewhere.
- Hide the keyboard.
- Scroll to some checkbox and check/uncheck it.
Expected results
No scrolling happens.
Actual results
The editor scrolls to the cursor.
Code sample
Code sample
[Paste your code here]
Screenshots or Video
Screenshots / Video demonstration
https://github.com/singerdmx/flutter-quill/assets/73047043/bf35263f-3735-4aa7-8ea0-7de1e5100da9
Logs
Logs
[Paste your logs here]
@singerdmx , could you please take a look since it looks similar to #619 you've fixed?
It's weird @singerdmx say this issue is fixed. This is the commit: https://github.com/singerdmx/flutter-quill/commit/7bd494a3d7ccdbde45a5f6e47ee79c4d7e6f1732
It's weird @singerdmx say this issue is fixed. This is the commit: 7bd494a
It might be a regression caused by another change, or it fixes it with a specific use case.
It might be a regression caused by another change, or it fixes it with a specific use case.
The changes from the commit are still applied, however, it is in raw_editor_state where they are now. Anyway, it seems that it only temporarily fixed the bug during those versions
The changes have a comment that says it's a workaround, it's looks like some other change affects how this workaround fixed it, which is generally one reason why we need more tests.
The changes have a comment that says it's a workaround, it's looks like some other change affects how this workaround fixed it, which is generally one reason why we need more tests
II contributed for a short period of time to AppFlowy-editor, and for every little new feature or fix, a test was done to make sure everything did what it should. They even have documentation about testing. I think we should start creating more tests about the package's functionalities. It would be good to have documentation about testing in this package, because for my part, I do not understand 100% how to test most of the package's functionalities.
I prefer to continue this discussion on Slack or GitHub Discussions or maybe with a different issue, as it’s not directly related to the technical aspects of this report.
To keep the issue report focused on the bug itself, including related bugs, fixes, and potential workarounds
For some reason, the bug above only happens when keyboard is closed. Maybe the commit has fixed it for a case when keyboard is open.