Multi-line style identification bug

[Alspb]

Is there an existing issue for this?

• [X] I have searched the existing issues

Flutter Quill version

master

Steps to reproduce

Select some multi-line text first part of which is non-bold while second part is bold.

Expected results

The selection style is shown as non-bold since not all the selected text is bold.

For example, it works fine if selection covers single line only. It also works fine if the first part is bold while the second is not.

Actual results

The selection style is shown as bold.

Code sample

Code sample

[Paste your code here]

Screenshots or Video

Bug:

Correct behavior:

Logs

Logs

[Paste your logs here]

[Alspb]

Looks that in version 9.3.7 many style identification bugs were fixed. @AtlasAutocode , could you please take a look if you're able to fix this one too.

[AtlasAutocode]

I believe I have identified the problem but need to test more and add some unit tests. I may also be able to assist with your other issues.

On a different note: I see that you contributed to improving text search. It would be really useful to have a Prev/Next option. Any chance you can look into this?

[Alspb]

@AtlasAutocode, thanks a lot.

I've actually planned to improve the search UI a bit in the nearest future: replace the search settings icons (case sensitive, etc.) with checkboxes, move the search widget to be displayed above the toolbar (since there's usually not enough space for both on mobile devices), an so on. Any suggestion are welcome. But Prev/Next buttons should be already there, they appear after you press "Find". Probably the idea is that you should have as much space as possible for entering the text you are searching for, so initially there's only one "Find" button instead of two "Prev", "Next".

As for the other issues, there were some problems with undo (it sometimes move cursor in an unusual way) which might even cause a crash, see issue 1289. But I will take a look soon. The most inconvenient issue is in my opinion 1297, since it influences text selection experience on mobile devices. But it probably might take time to understand how this piece of code works. I've also posted some issues recently, some of them are still open, but it looks like you've already closed most of the most important ones.