flutter-quill icon indicating copy to clipboard operation
flutter-quill copied to clipboard

read only not found in QuillEditorConfigurations

Open the-best-is-best opened this issue 1 year ago • 3 comments

Is there an existing issue for this?

Flutter Quill version

9.3.11

Steps to reproduce

nun

Expected results

nun

Actual results

nun

Code sample

QuillEditor.basic( configurations: QuillEditorConfigurations( controller: widget.controller ?? QuillController.basic(),

            readOnly: !widget.edit,
           
            scrollable: true,
            autoFocus: false,
            showCursor: widget.edit,
            expands: false,
            // maxHeight: MediaQuery.of(context).size.height * 0.25,
            padding: EdgeInsets.zero,
            sharedConfigurations: const QuillSharedConfigurations(
              locale: Locale('ar'),
            ),
          ),
        )

Screenshots or Video

No response

Logs

No response

the-best-is-best avatar May 12 '24 19:05 the-best-is-best

Update a litte in your code:

QuillEditor.basic(
   configurations: QuillEditorConfigurations(
      controller: widget.controller ?? QuillController(
         readOnly: !widget.edit, // <= Migrate to this
      ),
      scrollable: true,
      autoFocus: false,
      showCursor: widget.edit,
      expands: false,
      // maxHeight: MediaQuery.of(context).size.height * 0.25,
      padding: EdgeInsets.zero,
      sharedConfigurations: const QuillSharedConfigurations(
      locale: Locale('ar'),
   ),
),

hoangsang17th avatar May 13 '24 09:05 hoangsang17th

It made more sense before, why the (breaking) change?

apoleo88 avatar May 15 '24 17:05 apoleo88

It made more sense before, why the (breaking) change?

I don't know :))

hoangsang17th avatar May 16 '24 04:05 hoangsang17th

This is indeed a breaking change and it's not even mentioned inside the release notes :D

felix-mittermeier avatar May 21 '24 18:05 felix-mittermeier

@the-best-is-best Please mark done for this issue

hoangsang17th avatar May 22 '24 08:05 hoangsang17th