flutter-quill icon indicating copy to clipboard operation
flutter-quill copied to clipboard

Checkpoint always requests the keyboard focus when changing any value of the CheckList

Open milindgoel15 opened this issue 2 years ago • 10 comments

Issue with toolbar

Happens both on windows and android

Tried checking the quill toolbar icon theme on flutter_quill 8.0.0 and the iconTheme has no change on any icon in the toolbar.

image


      child: quill.QuillToolbar(
        configurations: quill.QuillToolbarConfigurations(
          multiRowsDisplay:
              quillToolbarMultiRowBox.get('isToolbarMultiRow') ?? false,
          toolbarSectionSpacing: 0,
          showFontFamily: false,
          toolbarSize: 42,
          decoration: BoxDecoration(
            borderRadius: const BorderRadius.all(Radius.circular(12)),
            color: isDesktop
                ? FluentTheme.of(context).scaffoldBackgroundColor
                : Theme.of(context).canvasColor,
          ),
          iconTheme: quill.QuillIconTheme(
            borderRadius: 8,
            disabledIconColor: isDesktop
                ? FluentTheme.of(context).acrylicBackgroundColor
                : Theme.of(context).colorScheme.primaryContainer,
            iconSelectedColor: isDesktop
                ? FluentTheme.of(context).accentColor
                : Theme.of(context).colorScheme.onPrimary,
            iconUnselectedColor: isDesktop
                ? FluentTheme.of(context).inactiveColor
                : Theme.of(context).colorScheme.onBackground,
            iconSelectedFillColor: isDesktop
                ? FluentTheme.of(context).cardColor
                : Theme.of(context).colorScheme.primary,
          ),
        ),
      ),

Issue with editor

The keyboard still pops up when checklist value changes even if requestKeyboardOnCheckListValueChange is false

Original issue: https://github.com/singerdmx/flutter-quill/issues/1440

milindgoel15 avatar Oct 26 '23 17:10 milindgoel15

That is because the new settings for the icon theme is in the button options

in there you will find a property called base and there you can customize the icon theme

I will remove the old icon theme

EchoEllet avatar Oct 26 '23 17:10 EchoEllet

Issue with toolbar

Happens both on windows and android

Tried checking the quill toolbar icon theme on flutter_quill 8.0.0 and the iconTheme has no change on any icon in the toolbar.

image

      child: quill.QuillToolbar(
        configurations: quill.QuillToolbarConfigurations(
          multiRowsDisplay:
              quillToolbarMultiRowBox.get('isToolbarMultiRow') ?? false,
          toolbarSectionSpacing: 0,
          showFontFamily: false,
          toolbarSize: 42,
          decoration: BoxDecoration(
            borderRadius: const BorderRadius.all(Radius.circular(12)),
            color: isDesktop
                ? FluentTheme.of(context).scaffoldBackgroundColor
                : Theme.of(context).canvasColor,
          ),
          iconTheme: quill.QuillIconTheme(
            borderRadius: 8,
            disabledIconColor: isDesktop
                ? FluentTheme.of(context).acrylicBackgroundColor
                : Theme.of(context).colorScheme.primaryContainer,
            iconSelectedColor: isDesktop
                ? FluentTheme.of(context).accentColor
                : Theme.of(context).colorScheme.onPrimary,
            iconUnselectedColor: isDesktop
                ? FluentTheme.of(context).inactiveColor
                : Theme.of(context).colorScheme.onBackground,
            iconSelectedFillColor: isDesktop
                ? FluentTheme.of(context).cardColor
                : Theme.of(context).colorScheme.primary,
          ),
        ),
      ),

Issue with editor

The keyboard still pops up when checklist value changes even if requestKeyboardOnCheckListValueChange is false

Original issue: #1440

I just removed the old property in the last pull request I sent, but for now, you can try passing the value to the new button options and let me know if the issue is fixed

EchoEllet avatar Oct 26 '23 17:10 EchoEllet

That is because the new settings for the icon theme is in the button options

That is why documentation is a crucial part of development. Never miss it.

milindgoel15 avatar Oct 26 '23 17:10 milindgoel15

That is because the new settings for the icon theme is in the button options

That is why documentation is a crucial part of development. Never miss it.

Sure I find a lot of bugs when documenting any code I use but now the time is tight and I can't for now but I will fix all the issues provide more features and maintain it

but I will soon

EchoEllet avatar Oct 26 '23 17:10 EchoEllet

That is because the new settings for the icon theme is in the button options

That is why documentation is a crucial part of development. Never miss it.

Did the issue get fixed??

EchoEllet avatar Oct 26 '23 17:10 EchoEllet

Issue with toolbar

Happens both on windows and android

Tried checking the quill toolbar icon theme on flutter_quill 8.0.0 and the iconTheme has no change on any icon in the toolbar.

image

      child: quill.QuillToolbar(
        configurations: quill.QuillToolbarConfigurations(
          multiRowsDisplay:
              quillToolbarMultiRowBox.get('isToolbarMultiRow') ?? false,
          toolbarSectionSpacing: 0,
          showFontFamily: false,
          toolbarSize: 42,
          decoration: BoxDecoration(
            borderRadius: const BorderRadius.all(Radius.circular(12)),
            color: isDesktop
                ? FluentTheme.of(context).scaffoldBackgroundColor
                : Theme.of(context).canvasColor,
          ),
          iconTheme: quill.QuillIconTheme(
            borderRadius: 8,
            disabledIconColor: isDesktop
                ? FluentTheme.of(context).acrylicBackgroundColor
                : Theme.of(context).colorScheme.primaryContainer,
            iconSelectedColor: isDesktop
                ? FluentTheme.of(context).accentColor
                : Theme.of(context).colorScheme.onPrimary,
            iconUnselectedColor: isDesktop
                ? FluentTheme.of(context).inactiveColor
                : Theme.of(context).colorScheme.onBackground,
            iconSelectedFillColor: isDesktop
                ? FluentTheme.of(context).cardColor
                : Theme.of(context).colorScheme.primary,
          ),
        ),
      ),

Issue with editor

The keyboard still pops up when checklist value changes even if requestKeyboardOnCheckListValueChange is false

Original issue: #1440

As for the editor issue Do you change the checklist values or toggle them?? there is a separated settings for that

EchoEllet avatar Oct 26 '23 18:10 EchoEllet

Issue with toolbar

Happens both on windows and android

Tried checking the quill toolbar icon theme on flutter_quill 8.0.0 and the iconTheme has no change on any icon in the toolbar.

image


      child: quill.QuillToolbar(
        configurations: quill.QuillToolbarConfigurations(
          multiRowsDisplay:
              quillToolbarMultiRowBox.get('isToolbarMultiRow') ?? false,
          toolbarSectionSpacing: 0,
          showFontFamily: false,
          toolbarSize: 42,
          decoration: BoxDecoration(
            borderRadius: const BorderRadius.all(Radius.circular(12)),
            color: isDesktop
                ? FluentTheme.of(context).scaffoldBackgroundColor
                : Theme.of(context).canvasColor,
          ),
          iconTheme: quill.QuillIconTheme(
            borderRadius: 8,
            disabledIconColor: isDesktop
                ? FluentTheme.of(context).acrylicBackgroundColor
                : Theme.of(context).colorScheme.primaryContainer,
            iconSelectedColor: isDesktop
                ? FluentTheme.of(context).accentColor
                : Theme.of(context).colorScheme.onPrimary,
            iconUnselectedColor: isDesktop
                ? FluentTheme.of(context).inactiveColor
                : Theme.of(context).colorScheme.onBackground,
            iconSelectedFillColor: isDesktop
                ? FluentTheme.of(context).cardColor
                : Theme.of(context).colorScheme.primary,
          ),
        ),
      ),

Issue with editor

The keyboard still pops up when checklist value changes even if requestKeyboardOnCheckListValueChange is false

Original issue: https://github.com/singerdmx/flutter-quill/issues/1440

The issue is related to the way the how does the CheckPoint and the editor work

You can always try to fix it by sending a pull request

It's on our to-do list, but it will take some time.

Feel free to ask us any other questions.

EchoEllet avatar Oct 26 '23 21:10 EchoEllet

Did the issue get fixed??

Yea the iconTheme works now.

milindgoel15 avatar Oct 27 '23 10:10 milindgoel15

One more thing, could u add icon spacing in the toolbar as the icons looks very congested in the mobile?

image

milindgoel15 avatar Oct 27 '23 10:10 milindgoel15

One more thing, could u add icon spacing in the toolbar as the icons looks very congested in the mobile?

image

Sure

EchoEllet avatar Oct 27 '23 16:10 EchoEllet