tap-mongodb icon indicating copy to clipboard operation
tap-mongodb copied to clipboard

Published 20 hours ago • verified publisher icon singer-io

Fix duplicated rows

Open Tolsto opened this issue 4 years ago • 1 comments

Description of change

Query oplog with 'gt' instead of 'gte'. Querying with 'gte' will lead to duplicated rows if the last oplog entry is for a collection that is supposed to be replicated. Because of the change done in efd5e0fd769b749f247266a88f617a0e617d380a this will not happen for every sync as it's quite likely that the last oplog entry references a modification in a different collection.

QA steps

  • [ ] automated tests passing
  • [ ] manual qa steps passing (list below)

Risks

Rollback steps

  • revert this branch

Tolsto avatar Jan 30 '21 20:01 Tolsto

Hi @Tolsto, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

cmerrick avatar Jan 30 '21 20:01 cmerrick