tap-google-sheets
tap-google-sheets copied to clipboard
feat: use the official Google API python library
Description of change
These changes will make use of the official google-api-python-client
library instead of relying on manual HTTP requests.
There are two main advantages of these changes:
- the Tap doesn't need to worry about the Google API interaction details as its hidden away by the Google official lib.
- We can use the authentication helpers from the lib to ease the
credentials management for the user. In that way the current PR
implements two auth mean:
- installed OAuth client authentication
- Service Accounts authentication.
Manual QA steps taken
- [x] individual testing of each google api call
- [x] tested in
--discover
mode - [x] tested in “sync” mode (with a
--catalog
argument)
Risks
The only downside of this change is that it breaks the current
config.json
parameters for existing users.
Hi @paulRbr, thanks for your contribution!
In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.
You did it @paulRbr!
Thank you for signing the Singer Contribution License Agreement.
Hi @kspeer825, hi @jeffhuth-bytecode what do you think of this change? Thanks!
Hi @kspeer825, hi @jeffhuth-bytecode what do you think of this change? Thanks!
Hello, we have a backlog ticket to review this change. Thanks for your contribution!