tap-google-sheets icon indicating copy to clipboard operation
tap-google-sheets copied to clipboard

feat: use the official Google API python library

Open paulRbr opened this issue 4 years ago • 4 comments

Description of change

These changes will make use of the official google-api-python-client library instead of relying on manual HTTP requests.

There are two main advantages of these changes:

  • the Tap doesn't need to worry about the Google API interaction details as its hidden away by the Google official lib.
  • We can use the authentication helpers from the lib to ease the credentials management for the user. In that way the current PR implements two auth mean:
    • installed OAuth client authentication
    • Service Accounts authentication.

Manual QA steps taken

  • [x] individual testing of each google api call
  • [x] tested in --discover mode
  • [x] tested in “sync” mode (with a --catalog argument)

Risks

The only downside of this change is that it breaks the current config.json parameters for existing users.

paulRbr avatar Nov 19 '20 11:11 paulRbr

Hi @paulRbr, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

cmerrick avatar Nov 19 '20 11:11 cmerrick

You did it @paulRbr!

Thank you for signing the Singer Contribution License Agreement.

cmerrick avatar Nov 19 '20 11:11 cmerrick

Hi @kspeer825, hi @jeffhuth-bytecode what do you think of this change? Thanks!

paulRbr avatar Nov 20 '20 23:11 paulRbr

Hi @kspeer825, hi @jeffhuth-bytecode what do you think of this change? Thanks!

Hello, we have a backlog ticket to review this change. Thanks for your contribution!

kspeer825 avatar Nov 30 '20 14:11 kspeer825