tap-google-analytics
tap-google-analytics copied to clipboard
Tdl 12607 add page size as a configurable property
Description of change
- Added is a configurable pagination parameter
page_size
. - Added pagination test case.
QA steps
- Give the
page_size
parameter in the config and verify that tap calls the API with the given pagination parameter. - Verify that if
page_size
parameter is not provided then tap consider defaultpage_size
1000.
Risks
Rollback steps
- revert this branch
This needs test coverage around the new configurable property:
- Can the tap handle types that are not int?
- What happens if I pass in a page size of zero?
- Does the tap actually fall back to the default and perform functionally?
We have updated the code to handle different values of the page_size
parameter.
The tap passes the default value of page_size
if page_size
is 0, empty string, invalid string, negative int, negative float.
Tap converts valid string and float values to int.