tap-github icon indicating copy to clipboard operation
tap-github copied to clipboard
verified publisher icon singer-io

Support custom domain (gh:e)

Open udzura opened this issue 5 years ago • 4 comments

Description of change

Support GitHub Enterprise. This will fix #23 .

Manual QA steps

  • Add something like "api_endpoint": "https://git.your-compony.example.com/api/v3" to your config json.
  • Run extractor.

Risks

  • Maybe none.

Rollback steps

  • Revert this branch

udzura avatar Apr 08 '20 10:04 udzura

Hi @udzura, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

cmerrick avatar Apr 08 '20 10:04 cmerrick

Singed! I'm waiting for the response.

udzura avatar Apr 09 '20 07:04 udzura

You did it @udzura!

Thank you for signing the Singer Contribution License Agreement.

cmerrick avatar Apr 11 '20 10:04 cmerrick

This is much needed. Any chance someone could review this please?

BenjMaq avatar Mar 10 '21 16:03 BenjMaq