tap-facebook icon indicating copy to clipboard operation
tap-facebook copied to clipboard

Return exit code 0 on failure

Open GuillaumeDesforges opened this issue 4 years ago • 0 comments

Description of the bug

Calling CLI tap-facebook returns exit code 0 even when it fails.

Expected behavior

Failed call should return exit code 1.

This is important for instance when calling the tool from airflow: airflow thinks the task succeeded when it did not.

Investigation

This is caused by https://github.com/litl/backoff/issues/72

Proposal

Set on_giveup to a function raising an exception.

GuillaumeDesforges avatar Dec 10 '20 10:12 GuillaumeDesforges