singer-tap-template icon indicating copy to clipboard operation
singer-tap-template copied to clipboard

Avoid trying to find max between None and non None value

Open pvonglehn opened this issue 1 year ago • 1 comments

Description of change

fixes #19

Set the value of max_bookmark to the first value of the bookmark column directly without comparing the first value of the bookmark column to None. This avoids TypeError from max(None, 1)

Manual QA steps

Set up a new tap project with non None bookmark column and run the tap

Risks

Rollback steps

  • revert this branch

pvonglehn avatar Apr 16 '23 13:04 pvonglehn

@nick-mccoy @dmosorast @aaronsteers could you kindly review or let me know who can, thanks!

pvonglehn avatar Apr 16 '23 13:04 pvonglehn