singer-python icon indicating copy to clipboard operation
singer-python copied to clipboard

Pass kwargs to json.dumps in singer.format_message

Open jlujan-omg opened this issue 6 years ago • 4 comments

Allow configuring json encoder by passing kwargs through to json.dumps in singer.format_message. Use case is passing data from pandas.DataFrame containing NaN to encode as null

jlujan-omg avatar May 21 '19 18:05 jlujan-omg

Hi @jlujan-omg, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

cmerrick avatar May 21 '19 18:05 cmerrick

You did it @jlujan-omg!

Thank you for signing the Singer Contribution License Agreement.

cmerrick avatar May 21 '19 19:05 cmerrick

When will this be merged, @cmerrick? This is very important as currently (as just one example) anything which needs to write a RecordMessage in non-ASCII is not possible.

kulte avatar Sep 05 '19 21:09 kulte

The package version updates are unrelated and therefore should be excluded.

And a test would be nice to proof that is works + better coverage. A non-ASCII test is useful, setting the json.dumps(..., ensure_ascii=False). I think this setting should default to False if you ask me.

abij avatar Mar 30 '20 10:03 abij