Add ca-certificate & use local image

[nethunteros]

singelet/docker-facece does no exists so we have to use local image

Fix for alpine image in Dockerfile using ca-certificate corrects this error: FATA[0016] Error writing outputs: Error writing iso-efi output: docker pull linuxkit/mkimage-iso-efi:1cebc76eab89254f3e288526890bbc7cddf0ffaf failed: exit status 1 output

Signed-off-by: binkybear [email protected]

[singe]

I've fixed the remote repo name in the yml, thanks for the catch. I've also added your apk cache cleanup to the Dockerfile. Thanks.

I've seen that error before, I fixed it by doing this in the LinuxKit dir:

foo=$(grep 'iso-efi":  ' src/cmd/linuxkit/vendor/github.com/moby/tool/src/moby/output.go|cut -d\" -f4)
docker pull $foo

I'm not sure why ca-certificates would fix a problem pulling the mkimage-iso-efi image. Can you elaborate?

[nethunteros]

Sure. This was the error:

Add service containers:
  Create OCI config for linuxkit/acpid:v0.4
  Create OCI config for linuxkit/getty:44730fd0a7c59dbacf5b48b54ba33f551bcf7ef0
  Create OCI config for linuxkit/openntpd:v0.4
  Create OCI config for linuxkit/vsudd:v0.4
  Create OCI config for linuxkit/vpnkit-forwarder:v0.4
  Create OCI config for linuxkit/trim-after-delete:v0.4
  Create OCI config for linuxkit/host-timesync-daemon:v0.4
  Create OCI config for docker:17.07.0-ce-dind
  Create OCI config for docker-fakece:1.0
Create outputs:
  docker-for-mac-wifi-efi.iso
FATA[0016] Error writing outputs: Error writing iso-efi output: docker pull linuxkit/mkimage-iso-efi:1cebc76eab89254f3e288526890bbc7cddf0ffaf failed: exit status 1 output:

Searching on the error brought me here: https://github.com/linuxkit/linuxkit/issues/2838#issuecomment-355815567

Adding ca-certificates to alpine image fixed the issue for me. Thought it was a bit odd but the fix mentioned in the comment worked.

I can close this PR if you like.

[singe]

Don’t yet. I’d like to test it on a clean setup my side. It makes sense and I think you’re right, and will end up making the change. Thanks for the help!

On 04 Jul 2018, at 00:22, binkybear [email protected] wrote:

Sure. This was the error:

Add service containers: Create OCI config for linuxkit/acpid:v0.4 Create OCI config for linuxkit/getty:44730fd0a7c59dbacf5b48b54ba33f551bcf7ef0 Create OCI config for linuxkit/openntpd:v0.4 Create OCI config for linuxkit/vsudd:v0.4 Create OCI config for linuxkit/vpnkit-forwarder:v0.4 Create OCI config for linuxkit/trim-after-delete:v0.4 Create OCI config for linuxkit/host-timesync-daemon:v0.4 Create OCI config for docker:17.07.0-ce-dind Create OCI config for docker-fakece:1.0 Create outputs: docker-for-mac-wifi-efi.iso FATA[0016] Error writing outputs: Error writing iso-efi output: docker pull linuxkit/mkimage-iso-efi:1cebc76eab89254f3e288526890bbc7cddf0ffaf failed: exit status 1 output: Searching on the error brought me here: linuxkit/linuxkit#2838 (comment)

Adding ca-certificates to alpine image fixed the issue for me. Thought it was a bit odd but the fix mentioned in the comment worked.

I can close this PR if you like.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[singe]

Ugh, I can't reproduce the error now. What state was your system in before the error? brew'd linuxkit, what else?