Seppo Ingalsuo

Results 201 comments of Seppo Ingalsuo

There's two commits from your previous PRs included to this, only the third commit is relevant. I don't think there's any dependency so you can leave them out from this.

I did a performance comparison with git main vs main + #9170 with TGL build with gcc and xcc. The gcc build currently can't run enabled DRC (reason unknown, a...

Similar result with MTL, no improvement with xcc build, and about same 4 MCPS slower with gcc build of this PR.

I used for test these compiler versions - TGL gcc: xtensa-intel_tgl_adsp_zephyr-elf-gcc (Zephyr SDK 0.16.4) 12.2.0 - MTL gcc: xtensa-intel_ace15_mtpm_zephyr-elf-gcc (Zephyr SDK 0.16.4) 12.2.0 - TGL xcc: xt-xcc version 12.0.8, RG-2017.8-linux,...

Used algorithms settings for xcc ``` amixer cset name='Post Mixer Analog Playback Volume' 44 amixer cset name='Pre Mixer Analog Playback Volume' 44 sof-ctl -n 34 -s ~/ctl4/eq_iir_spk.txt sof-ctl -n 35...

It's not clear if you want to keep #9160, or want to include the previous change into this PR (and close #9160). I think separate PR is better, so you...

> Lets wait for @singalsu to return before we merge. We don't have CI validation for these features and @ShriramShastry is without DUTs to run tests. So bear with me,...

Adding that this PR saves when sound angle tracking is enabled in TGL 4 mic case from 134 MCPS average to 120 MPCS average. Also test tools/test/audio/tdfb_direction_test.m is passed.

> This looks fine to me but @singalsu needs to review. > > Long term @ShriramShastry @singalsu thinking aloud, I think it may make more sense to have Kconfig that...