sindresorhus
Parsing of `arrayFormat: 'comma'` not working for queries of single value with comma
Say we have an Object we are stringifying to become a query param of the following shape (notice the comma in the value)
- Create an object with its value as a single string / array of one string.
const singleQueryObject = { not_important: [ "I, am, one, single, value"]};
// OR (the value can also just be a plain string, not an array like the above)
const singleQueryObject = { not_important: "I, am, one, single, value" };
- We stringify it:
const stringifyResult = queryString.stringify(singleQueryObject, { arrayFormat: 'comma' });
//=> 'not_important=I%2C%20am%2C%20one%2C%20single%2C%20value'
- We parse it (Actual)
const parsedResult = queryString.parse(stringifyResult, { arrayFormat: 'comma' });
//=> { not_important: [ 'I', ' am', ' one', ' single', ' value' ] }
(Expected)
{ not_important: [ 'I, am, one, single, value' ] };
Work around (?)
This bug only occurs when there is a single value. So say if we run the same step as above with this object instead:
const singleQueryObject = { not_important: [ 'I, am, one, single, value', 'It works!'] };
const stringifyResult = queryString.stringify(singleQueryObject, { arrayFormat: 'comma' });
const parsedResult = queryString.parse(stringifyResult, { arrayFormat: 'comma' });
//=> { not_important: [ 'I, am, one, single, value', 'It works!' ] }
@sindresorhus @Richienb This is also causing issues on our side ? Any timeline for this fix ?
The current parse API doesn't appear to have enough information to solve this problem.
One solution might be an option to encode array-ness into the parameter key during stringify, resulting in something like myArray[]=a,b,c. I could imagine this gracefully degrading for backwards compatible if the development philosophy requires it.
This line is causing the problem: https://github.com/sindresorhus/query-string/blob/main/index.js#L177
In order for this to be fixed in a backwards compatible fashion an option would need to be introduced that allows prevention of the use of 'encoded arrays'.
