Cannot exit pure

[sbmueller]

General information

• Pure version: 1.8.0
• ZSH version: 5.5.1
• Terminal program & version: mintty 2.9.0
• Operating system: Windows 10
• ZSH framework: oh-my-zsh

I have:

• [x] Followed the Integration instructions for my framework

Problem description

I cannot exit pure once I start zsh. exit or logout command seem not to finish. After pressing enter, I'm just in a new line where I can continue to write (with a high latency).

Reproduction steps

1. Install pure
2. Start zsh
3. Type exit and press enter
4. Zsh does not exit and seems to hang

My .zshrc:

ZSH_THEME = ""
plugins = ( gitfast )
source $ZSH/oh-my-zsh.sh
autoload -U promptinit; promptinit
prompt pure

[sbmueller]

The zsh processes seem to never get killed, even when killing the tmux window:

[mafredri]

Hi, unfortunately this is a Zsh on Windows bug which is related to using zpty's. There's some more information on this available here: https://github.com/mafredri/zsh-async/issues/26, #141 and #146.

Something like https://github.com/mafredri/zsh-async/issues/24 could help, but no work has been done on it yet nor has this assumption been validated.

[mafredri]

Hey @sbmueller, would you be able to try out the no-zpty branch of zsh-async? I'm curious if that method might work for you.

But please keep in mind that it was a super quick hack to test how zsh-async would behave without zpty 😄.

[sbmueller]

@mafredri I think this solves the mentioned problems 😲

[mafredri]

That's great news, thanks for testing 😄! Going to be off on vacation for a week but after that I'll try to wrap it up into something useable.

[oryband]

Hey @sbmueller, would you be able to try out the no-zpty branch of zsh-async? I'm curious if that method might work for you.

But please keep in mind that it was a super quick hack to test how zsh-async would behave without zpty smile.

this needs to be added to the readme or wiki

[mafredri]

@oryband I'd prefer not, until I've had more time to work on the no-zpty branch.

[otterpro]

I was also having the issue on Cygwin/mintty, as I couldn't exit out of the zsh shell. Fortunately, no-zpty branch seems to fix the problem. thank you.

[lminer]

What happened to the no-zpty branch? I'm having this issue on cygwin

[mafredri]

@lminer It's still there, I just haven't worked on it since. It does work, but not fully featured, which can cause race conditions. I was actually using it on macOS for a month or two without realizing 😂... Hoping to get around to finishing it soon, but no promises.

[mafredri]

There's a small chance that the async refactor and improvements in #543 might have fixed these issues. It'd be super if someone could test it out!

[mafredri]

I haven't had time to work on this, so I've added the help wanted label. If someone is interested in working on this, continuing on the no-zpty work in zsh-async may be the best approach. Open to alternative solutions too!