np icon indicating copy to clipboard operation
np copied to clipboard

Ability to pass in sign flag to Git

Open riyadhalnur opened this issue 8 years ago • 6 comments

Since GitHub now supports signed commits and tags, the ability to pass in the -S flag to git would come in handy, IMO.

riyadhalnur avatar Jul 10 '16 09:07 riyadhalnur

You can already have Git tags signed: https://github.com/sindresorhus/np/commit/4954429422cd1f4ee0bebd45d4a319d8a507780d

To get signed commits, you need to request a similar config from npm. np uses npm version underneath to bump the version, commit, and tag. Open an issue on https://github.com/npm/npm/issues and comment the link here.

sindresorhus avatar Jul 10 '16 09:07 sindresorhus

Cool. Didn't know that. Setting the npm config will do it then. Don't think an issue is necessary in that case.

riyadhalnur avatar Jul 10 '16 09:07 riyadhalnur

Well, it is if you also want the commit signed.

sindresorhus avatar Jul 10 '16 09:07 sindresorhus

Right, but np isn't explicitly committing anything is it? After bumping version, if np commits the changes itself, then yes, signing that commit would come in handy.

riyadhalnur avatar Jul 10 '16 09:07 riyadhalnur

@riyadhalnur As I said:

np uses npm version underneath to bump the version, commit, and tag.

sindresorhus avatar Jul 10 '16 10:07 sindresorhus

https://github.com/npm/npm/issues/12696

riyadhalnur avatar Jul 10 '16 15:07 riyadhalnur

The git commit and tag is handled by npm version. There doesn't seem any open request for that anymore on npm’s many support channels, so I'm closing this since it's been 6 years.

Feel free to reopen after npm implements it and if any change is required in np at all (considering that git tags can already be signed without asking np https://github.com/sindresorhus/np/commit/4954429422cd1f4ee0bebd45d4a319d8a507780d)

fregante avatar Feb 03 '23 12:02 fregante