Notifier stays offline despite regaining connection

[benrondeau]

When Chrome goes offline and the extension looses connection to Github, it shows a yellow text bubble saying off (or something similar). When you regain internet connection, this bubble stays in place and the only way to reconnect is to manually click on the plugin icon. I have had the plugin be in 'offline' mode for long periods of time and therefore missed notifications.

Ideally, the plugin would re-connect itself and not require the user to click on the plugin icon to reconnect to Github. Not very familiar with the Chrome API but if it does not expose a method to be notified upon regaining internet connection, something like a setTimeout that pings the URL every 5 seconds until a connection could be another solution.

@sindresorhus Any thoughts? I will create a PR if you will accept it.

---

IssueHunt Summary

Backers (Total: $40.00)

• issuehunt ($40.00)

Submitted pull Requests

• #196 Fix offline badges even when network is already online

---

Become a backer now!

Or submit a pull request to get the deposits!

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

---

IssueHunt has been backed by the following sponsors. Become a sponsor

[EvertEt]

Should be working since https://github.com/sindresorhus/notifier-for-github-chrome/pull/123 due to the window.addEventListener.

[benrondeau]

This is not working for me, unfortunately. I have not investigated specifically why, but it does not work with my setup:

Google Chrome Version v58.0.3029.110 (64-bit)
Notifier for GitHub v3.0.3
Mac OSX 10.12.5

It will stay offline for as long as I let it. I put my computer to sleep numerous times throughout the day and when I come back, I have to manually reconnect the plugin (clicking on the icon).

[benrondeau]

Upgraded to Google Chrome v59.0.3071.86 (Official Build) (64-bit) and the problem still exists.

[ghost]

Has been updated to https://github.com/sindresorhus/notifier-for-github-chrome/archive/3.0.4.zip

[benrondeau]

@sindresorhus - You didn't update the manifest version from 3.0.3 to 3.0.4

[gcochard]

@benrondeau make sure to build the extension with npm run build before trying to load it if you haven't already done that.

[benrondeau]

@gcochard Thanks. I installed it and got this notification:

[ExE-Boss]

@benrondeau @EvertEt#129 That is tracked by Chromium Bug 677855 (Status: WontFix), but otherwise the extension works fine.

[midenok]

Reproduces for me. The extension don't work for more than half-year.

Google Chrome Version 55.0.2883.87 (64-bit)
Notifier for GitHub 3.0.5

[jakeonrails]

I'm on 3.0.5 and when I go back and forth between work and home the extension is "OFF" and I have to click to turn it on again. Can it be made to just automatically connect when the browser is first opened instead?

[sindresorhus]

Yes, we should get this fixed.

---

Note: This issue has a bounty, so it's expected that you are an experienced programmer and that you give it your best effort if you intend to tackle this. Don't forget, if applicable, to add tests, docs (double-check for typos), and update TypeScript definitions. And don't be sloppy. Review your own diff multiple times and try to find ways to improve and simplify your code. Instead of asking too many questions, present solutions. The point of an issue bounty is to reduce my workload, not give me more. Thanks for helping out 🙌

[issuehunt-oss[bot]]

@issuehunt has funded $40.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.