gulp-filter icon indicating copy to clipboard operation
gulp-filter copied to clipboard

Gulp filter filters everything

Open sherlock1982 opened this issue 6 years ago • 4 comments

Issuehunt badges

Version 5.0.0 works ok, version 5.0.1 broken. Looks like a change was made between 5.0.0 and 5.0.1 and now filter just skips everything. Here's a simplified code snippet which:

function(svn_revision){
    var xmlFilter = filter("../**/*.xml", {restore: true});

    return gulp.src([
            "../Setup/Installed/Data/Http/Templates/**/*",
        ], { base : '../' })
        .pipe(xmlFilter)
        .pipe(replace('@PRODUCT_SVN_BUILD@', svn_revision))
        .pipe(xmlFilter.restore)
        .pipe(gulp.dest("../BinRepo/Templates"));
},

Expected behavior: All xml files should have @PRODUCT_SVN_BUILD@ replaced. Actual behavior: Looks like they're just written to dest folder.

UPD: Looks like 5.0.0 doesn't work on Linux


IssueHunt Summary

Sponsors (Total: $40.00)

Become a sponsor now!

Or submit a pull request to get the deposits!

Tips

sherlock1982 avatar Mar 05 '18 12:03 sherlock1982

+1 same here, downgrading

gchamon avatar Jun 26 '18 15:06 gchamon

4 is also broken here, sticking with ~3.0

gchamon avatar Jun 26 '18 15:06 gchamon

Version 5.1.0 - broken. Filters out everything.

sergeymorkovkin avatar Dec 11 '18 19:12 sergeymorkovkin

@issuehunt has funded $40.00 to this issue.


IssueHuntBot avatar Jun 09 '19 05:06 IssueHuntBot