got icon indicating copy to clipboard operation
got copied to clipboard

Quick start

Open ydarma opened this issue 2 years ago • 8 comments

Checklist

  • [X] I have read the documentation.
  • [X] I have included a pull request description of my changes.
  • [ ] I have included some tests.
  • [ ] If it's a new feature, I have included documentation updates in both the README and the types.

Quick start guide. Fix #2016.

ydarma avatar Jun 11 '22 11:06 ydarma

All my comments apply in multiple places. I did not comment on all the places, but it's implied.

sindresorhus avatar Jun 13 '22 07:06 sindresorhus

All my comments apply in multiple places. I did not comment on all the places, but it's implied.

I understood, I tried to apply suggestions everywhere but maybe I missed something... I'll review again

ydarma avatar Jun 13 '22 07:06 ydarma

I have pushed some minor improvements: https://github.com/sindresorhus/got/pull/2059/commits/a4fed5a4339b1d43335b30c2c534f5650c3c1e30

sindresorhus avatar Jul 05 '22 19:07 sindresorhus

I think the text still needs improvements. There were many typos and there are probably some left too. Try to go through the text and improve it.

sindresorhus avatar Jul 05 '22 19:07 sindresorhus

I think the text still needs improvements.

I read the text multiple times and I am afraid I am not able to improve it. I am stuck with my English. If you think about writing style, sorry I won't be able to go further. If you think about more detailed information I can try to go into details. However I think that the quick start should be kept short with pointers to the doc.

Thank for the fixes, I admit that I could have avoid some if I were more careful, but not all of them.

ydarma avatar Jul 25 '22 07:07 ydarma

You could use something like https://grammarly.com

sindresorhus avatar Jul 25 '22 16:07 sindresorhus

Thanks, I'll try that ASAP

ydarma avatar Jul 25 '22 16:07 ydarma

I applied Grammarly suggestions. The tool showed excellent indicator figures (clarity, engagement, and delivery).

ydarma avatar Jul 28 '22 07:07 ydarma

Thanks :)

sindresorhus avatar Aug 30 '22 05:08 sindresorhus