got
got copied to clipboard
Add option to disable UNIX domain sockets
https://github.com/sindresorhus/got/blob/main/documentation/tips.md#unix-domain-sockets
It's a niche feature and have heard that some teams have their own custom code to prevent it, so it makes sense to have the ability to turn it off in Got.
I suggest:
- [ ] Add option to turn off support for UNIX domain sockets. Make it
false
by default. - [ ] In Got v13 (next major release), change it to be
true
by default.
Open questions:
- Should a Unix socket be able to redirect to HTTP?
Haha, I'll pick up this one!
So when the setting is turned to false
, the following won't work?
got('unix:/var/run/docker.sock:/containers/json');
@TommyDew42 Correct. Also the http:
version, per the docs.
Is there anything to work with this? I guess, the issue is resolved, the maintainers should mark as closed.