create-dmg icon indicating copy to clipboard operation
create-dmg copied to clipboard

Published 20 hours ago • verified publisher icon sindresorhus

Build version not matching version in package.json

Open aubreypwd opened this issue 4 years ago • 2 comments

When I bump the version in package*.json and I run, e.g.

./node_modules/.bin/create-dmg './build/Twitter-darwin-x64/Twitter.app' --overwrite --dmg-title='Twitter' --identity='Aubrey Portwood' ./dist/"

The version in dist/ is always 1.0.0.

image

aubreypwd avatar Oct 24 '20 15:10 aubreypwd

Did you rebuild it with electron-packager after updating the version? This module doesn't use the info on your package.json directly, it uses the info of the package.json inside of your packaged app

fcastilloec avatar Mar 11 '21 22:03 fcastilloec

I did not, I have used it successfully to package a folder with a .app in it that get's built by nativefier. I will look into this more and report back if I can.

aubreypwd avatar Mar 22 '21 15:03 aubreypwd