Sindre Sorhus comments

Results 4030 comments of


                                            Sindre Sorhus

trafficstars

Rule proposal: `call-arguments-length`

I think we should ship with a default preset for this rule that covers a lot of built-ins.

Rule proposal: `call-arguments-length`

This is now accepted.

Rule proposal: `prefer-number-is-safe-integer`

Sounds useful. The only problem I can think of are the checks assuming the inverse case is not an integer. ```js if (Number.isInteger(x)) { } else { // Assumes this...

Rule proposal: opposite of `prefer-string-raw`

Accepted. We can just add it to `prefer-string-raw`.

Loop does not work properly

Where are you testing the GIF? macOS Quick Look does not correctly respect the count. You must drag the GIF into a browser to properly test it.

Loop does not work properly

Then it's more likely a problem with PowerPoint.

Rule proposal: No multiple array check in logical expression

Rule name: `no-multiple-array-checks-in-logical-expressions`?

Rule proposal: No multiple array check in logical expression

Accepted

Going to pass on this. `parse()` is intentionally **lossless** so you can distinguish `?a` (present, `null`) from `?a=` (present, `''`) and from **absent**. Skipping at parse time would silently drop...

Default Behaviour for `store.get(undefined)`

It should throw a user-friendly error.