Sindre Sorhus comments

Results 4181 comments of


                                            Sindre Sorhus

Feature/update priority

index.d.ts and readme should be in sync, specifically `setPriority`

Feature/update priority

Yes

One Queue, Multiple workers

Closing as out of scope. This would turn p-queue into an event bus. p-queue is feature-complete. Build this as a small wrapper on top or something new.

Is it feasible to change priority of a Queued item on the fly

There could maybe be a `.setPriority(fn, {priority})` method that could accept the original function you passed to `.add()` (for ID purposes) and let you change the priority.

Rule proposal: Prefer array `last` methods over `reverse`

Name: `prefer-array-last-methods`?

Rule proposal: Prefer array `last` methods over `reverse`

Accepted.

"This browser version is no longer supported. Please upgrade to a supported browser."

Plash uses the built-in Safari, not Chrome. I tried showing Google Calendar in Plash and I'm not seeing any warnings like this.

Rule proposal: Use `Array#includes()` instead of repeated conditional checks

> if (args[0] === '-h' || '--help') { I don't think I've ever seen this done before.

Rule proposal: Use `Array#includes()` instead of repeated conditional checks

I think this could be part of the [`prefer-includes`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-includes.md) rule.

Rule proposal: Use `Array#includes()` instead of repeated conditional checks

Let's first see if the other maintainers agree on this change.