Sindre Sorhus

Results 4167 comments of Sindre Sorhus

Hmm, we support a `Stream` in the `stdin`, `stdout`, `stderr` options now. Doesn't that solve the main use-case?

I agree with almost everything. However, I'm not a big fan of the `PASS:` and `FAIL:` noise. I think the icons are clear enough for the common case and we...

> @sindresorhus how strongly do you feel about this? I don't feel strongly about it.

> I do like the consistency. Most assertion will be pass or fail, so there wouldn't be much inconsistency in practice. And it may even have been beneficial to make...

@novemberborn It really depends on what the terminal renderer in GitHub Actions supports. All terminals support bold, but only some support underline/strikethrough/italic. You kinda just need to test and see.

GitHub Actions supports colors though, so not sure why it's not used. Maybe you need to upgrade Chalk for that.

> so we'd need a way to identify CI's and refine based on our knowledge? Any terminal and CI I know about that can display bold/underline, can also display colors.

Yes, we discussed this a while ago and agreed it would be very useful, but not a priority for 1.0.0. https://github.com/bahmutov/rocha is a good inspiration. > "I thought it was...

> We could consider running test files in a random order as well, though they're already somewhat random because each test file runs in its own process I think we...

I prefer `cleanup` too. Can we make it cleanup even on `uncaughtException`? I'd like cleanup to work no matter what happens.