Sindre Sorhus

Results 3699 comments of Sindre Sorhus

Failing: https://github.com/sindresorhus/eslint-plugin-unicorn/runs/7158388862?check_suite_focus=true

> I see linters as being checkers. I wouldn't expect them to just go and change my code. Can we change that perception? I see linters as helpers. Fixing my...

@bfred-it I'm not ready to experiment with this yet. I have too many things to deal with and I expect this to require a lot of follow up and tweaks.

Couldn't it apply to `Array` too? And maybe also `Object` and `Map` keys?

> We have prefer-set-has to report Arrays that are used like Sets and suggest converting them into Sets Sure, but someone may disable that rule, but still have this one...

How about naming it `no-duplicate-literal-elements`?

@quirimmo This is already answered in the issue body: > Sometimes a hardcoded Set grows large enough for it to be hard to see if there is already a value...

If anyone wants to work on this, see the initial attempt and feedback in https://github.com/sindresorhus/eslint-plugin-unicorn/pull/1635.

The reason I didn't use the command with arguments by default is that it's very verbose. It includes the full path to the binary. I could find no way to...