Sindre Sorhus
Sindre Sorhus
See: https://github.com/sindresorhus/execa/pull/170#issuecomment-539463497
Relevant Node.js issue: https://github.com/nodejs/node/issues/40438
This is not possible. There's no `column` / `row` on the spawned process. You need a PTY for that, like https://github.com/microsoft/node-pty See this Node.js issue: https://github.com/nodejs/node/issues/31409 I agree, it would...
> but I was wondering if it's possible to pass in a fake tty write stream that just collects the output. Probably not though if it's just a wrapper for...
Thanks for working on this 🙌 Make sure you add a *lot* of tests.
> should I squash the commits ? No need. We'll squash when merging.
I would like to see even more tests for this. It's a complicated feature (streams have a *lot* of edge-cases).
Would be nice to [DRY](https://en.wikipedia.org/wiki/Don%27t_repeat_yourself) up some code between the duplex method and the others.
In general for PRs: - Look over your own diff. - Try to improve the implementation. - Try to refactor and simplify. - Improve docs.
Users will complain either way. If we change the default, it will be a disruptive and breaking change for many users. There is no clear win-win situation as far as...