capture-website
capture-website copied to clipboard
page.close() and browser.close() should be in try-catch-finally block
Everytime something goes wrong capturing a screenshot (i.e. no response, timeouts, ...) the function exits without closing page and browser, so that chrome instances keep growing until server dies. Putting page.close() and browser.close() in a "finally" block should avoid resources leaking
I agree. Pull request welcome.
Ok, pull request done
Ok, pull request done
Is this issue resolved?
Was this ever merged? Because I'm having zombie processes and I imagine it's because of this