capture-website
capture-website copied to clipboard
fullPage is not working and causing zombie process
https://github.com/sindresorhus/capture-website/blob/master/index.js#L321 Based on this fullPage statment, is possible to find 3 problems
- it will never get inside the while loop. bodyBoundingHeight is an object. the correct should be bodyBoundingHeight.height
- waitForNavigation resolves when navigating to a new page. this is always crashing in timeout, never being resolved. (L331)
- crashing on the waitForFunction can cause zombie process since it won't get at the page.close() (L351)
I will open a PR for these items
// @netrules
These are already resolved in the new PR. Thanks a lot for reporting them, @johnyvelho , I can't believe I missed those before commit.