capture-website icon indicating copy to clipboard operation
capture-website copied to clipboard

fullPage is not working and causing zombie process

Open johnyvelho opened this issue 4 years ago • 2 comments

https://github.com/sindresorhus/capture-website/blob/master/index.js#L321 Based on this fullPage statment, is possible to find 3 problems

  1. it will never get inside the while loop. bodyBoundingHeight is an object. the correct should be bodyBoundingHeight.height
  2. waitForNavigation resolves when navigating to a new page. this is always crashing in timeout, never being resolved. (L331)
  3. crashing on the waitForFunction can cause zombie process since it won't get at the page.close() (L351)

I will open a PR for these items

johnyvelho avatar Aug 29 '20 04:08 johnyvelho

// @netrules

sindresorhus avatar Aug 29 '20 19:08 sindresorhus

These are already resolved in the new PR. Thanks a lot for reporting them, @johnyvelho , I can't believe I missed those before commit.

sgtrusty avatar Aug 29 '20 20:08 sgtrusty