awesome icon indicating copy to clipboard operation
awesome copied to clipboard

Add Microsoft Sentinel

Open kfriede opened this issue 2 years ago • 8 comments

https://github.com/kfriede/awesome-microsoft-sentinel

Resources for Microsoft Azure Sentinel and related KQL, SIEM, and SOAR functionality

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • [x] Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it. Instead use #2242 for incubation visibility.
  • [x] Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • [x] You have to review at least 2 other open pull requests.
    • https://github.com/sindresorhus/awesome/pull/2736
    • https://github.com/sindresorhus/awesome/pull/2647
  • [x] You have read and understood the instructions for creating a list.
  • [x] This pull request has a title in the format Add Name of List. It should not contain the word Awesome.
  • [x] Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
  • [x] Your entry should be added at the bottom of the appropriate category.
  • [x] The title of your entry should be title-cased and the URL to your list should end in #readme.
  • [x] No blockchain-related lists.
  • [x] The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • [x] Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • [x] Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • [x] The default branch should be named main, not master.
  • [x] Includes a succinct description of the project/theme at the top of the readme. (Example)
  • [x] It's the result of hard work and the best I could possibly produce.
  • [x] The repo name of your list should be in lowercase slug format: awesome-name-of-list.
  • [x] The heading title of your list should be in title case format: # Awesome Name of List.
  • [x] Non-generated Markdown file in a GitHub repo.
  • [x] The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • [x] Not a duplicate. Please search for existing submissions.
  • [x] Only has awesome items. Awesome lists are curations of the best, not everything.
  • [x] Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • [x] Includes a project logo/illustration whenever possible.
  • [x] Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • [x] Includes the Awesome badge.
  • [x] Has a Table of Contents section.
  • [x] Has an appropriate license.
  • [x] Has contribution guidelines.
  • [x] All non-important but necessary content (like extra copyright notices, hyperlinks to sources, pointers to expansive content, etc) should be grouped in a Footnotes section at the bottom of the readme. The section should not be present in the Table of Contents.
  • [x] Has consistent formatting and proper spelling/grammar.
  • [x] Does not use hard-wrapping.
  • [x] Does not include a CI (e.g. GitHub Actions) badge.
    You can still use a CI for linting, but the badge has no value in the readme.
  • [x] Does not include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

kfriede avatar Aug 18 '23 17:08 kfriede

Thanks for making an Awesome list! 🙌

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

sindresorhus avatar Aug 18 '23 19:08 sindresorhus

@sindresorhus I went through line-by-line when I checked everything off. Would you care to inform me what I'm missing so I can fix it?

kfriede avatar Aug 21 '23 10:08 kfriede

unicorn 🦄

kfriede avatar Aug 23 '23 12:08 kfriede

It seems this and this repositories already covers your topic

Also, your repository may not fit these criteria:

- [ ] It's the result of hard work and the best I could possibly produce.
	**If you have not put in considerable effort into your list, your pull request will be immediately closed.**

donbarbos avatar Sep 02 '23 10:09 donbarbos

  • Recommend renaming repo to "awesome-azure-sentinel" or "awesome-microsoft-sentinel"
  • Pull request title should match name of repo (e.g. without above change, "Add Sentinel")

infosecB avatar Oct 24 '23 23:10 infosecB

  • Recommend renaming repo to "awesome-azure-sentinel" or "awesome-microsoft-sentinel"
  • Pull request title should match name of repo (e.g. without above change, "Add Sentinel")

Updated repository name, no PR name change required (since repository name now matches PR)

kfriede avatar Oct 25 '23 11:10 kfriede

unicorn 🦄

kfriede avatar Oct 25 '23 11:10 kfriede

The list is a bit thin on content.

sindresorhus avatar Feb 14 '24 08:02 sindresorhus

It's also not following multiple of the guidelines, like . at the end of descriptions. I suggest working on it some more and try submitting it again at a later point (at least wait 6 months).

sindresorhus avatar Feb 14 '24 08:02 sindresorhus