awesome icon indicating copy to clipboard operation
awesome copied to clipboard
verified publisher icon sindresorhus

Add Clubhouse

Open ehsanghaffar opened this issue 3 years ago β€’ 19 comments

[https://github.com/ehsanghaffarii/awesome-clubhouse]

[A list of tools and resources for Clubhouse social audio app]

By submitting this pull request I confirm I've read and complied with the below requirements πŸ––

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests. Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting β€œlooks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List.
    • βœ… Add Swift
    • βœ… Add Software Architecture
    • ❌ Update readme.md
    • ❌ Add Awesome Swift
    • ❌ Add swift
    • ❌ add Swift
    • ❌ Adding Swift
    • ❌ Added Swift
  • Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
    • βœ… - [iOS](…) - Mobile operating system for Apple phones and tablets.
    • βœ… - [Framer](…) - Prototyping interactive UI designs.
    • ❌ - [iOS](…) - Resources and tools for iOS development.
    • ❌ - [Framer](…)
    • ❌ - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.
  • The title of your entry should be title-cased and the URL to your list should end in #readme.
    • Example: - [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • The default branch should be named main, not master.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • βœ… Mobile operating system for Apple phones and tablets.
    • βœ… Prototyping interactive UI designs.
    • ❌ Resources and tools for iOS development.
    • ❌ Awesome Framer packages and tools.
  • It's the result of hard work and the best I could possibly produce. If you have not put in considerable effort into your list, your pull request will be immediately closed.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
    • βœ… awesome-swift
    • βœ… awesome-web-typography
    • ❌ awesome-Swift
    • ❌ AwesomeWebTypography
  • The heading title of your list should be in title case format: # Awesome Name of List.
    • βœ… # Awesome Swift
    • βœ… # Awesome Web Typography
    • ❌ # awesome-swift
    • ❌ # AwesomeSwift
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
    • Must not feature Contributing or Footnotes sections.
  • Has an appropriate license.
    • We strongly recommend the CC0 license, but any Creative Commons license will work.
      • Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0 (replace <user> and <repo> accordingly).
    • A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
    • Place a file named license or LICENSE in the repo root with the license text.
    • Do not add the license name, text, or a Licence section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.
    • To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
    • It can optionally be linked from the readme in a dedicated section titled Contributing, positioned at the top or bottom of the main content.
    • The section should not appear in the Table of Contents.
  • All non-important but necessary content (like extra copyright notices, hyperlinks to sources, pointers to expansive content, etc) should be grouped in a Footnotes section at the bottom of the readme. The section should not be present in the Table of Contents.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't use hard-wrapping.
  • Doesn't include a Travis badge.
    You can still use Travis for list linting, but the badge has no value in the readme.
  • Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

ehsanghaffar avatar Jan 31 '22 07:01 ehsanghaffar

Thanks for making an Awesome list! πŸ™Œ

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

sindresorhus avatar Jan 31 '22 08:01 sindresorhus

For information, the lint check only gives errors of your edit in awesome readme itself, but you should also run awesome-lint on your own repo, see sindresorhus/awesome-lint

Thanks for the update, I will fix it and make sure that does not have problems to send. πŸ™ŒπŸΌ

ehsanghaffar avatar Feb 02 '22 13:02 ehsanghaffar

@ehsanghaffarii I checked the lint erros and pushed a PR for you: https://github.com/ehsanghaffarii/awesome-clubhouse/pull/1

michelpereira avatar Feb 06 '22 23:02 michelpereira

@ehsanghaffarii I checked the lint erros and pushed a PR for you: ehsanghaffarii/awesome-clubhouse#1

ok, Thanks for fixing it. I merged your PR

ehsanghaffar avatar Feb 07 '22 00:02 ehsanghaffar

Ok will do

Robert C. Ozuna

On Sun, Feb 6, 2022, 5:59 PM Ehsan Ghaffar @.***> wrote:

@ehsanghaffarii https://github.com/ehsanghaffarii I checked the lint erros and pushed a PR for you: ehsanghaffarii/awesome-clubhouse#1 https://github.com/ehsanghaffarii/awesome-clubhouse/pull/1

ok, Thanks for fixing it. I merged your PR

β€” Reply to this email directly, view it on GitHub https://github.com/sindresorhus/awesome/pull/2169#issuecomment-1030962750, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXOQ7E7PXENJADLZ74KFKQDUZ4KNRANCNFSM5NFQIYZA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

RobertCharles1988 avatar Feb 07 '22 01:02 RobertCharles1988

I am

Robert C. Ozuna

On Sun, Feb 6, 2022, 6:14 PM Ehsan Ghaffar @.***> wrote:

@.**** commented on this pull request.

I fixed all lint errors, please check and review πŸ™πŸΌ

β€” Reply to this email directly, view it on GitHub https://github.com/sindresorhus/awesome/pull/2169#pullrequestreview-874116182, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXOQ7E5OQA4BIHDZVDFZWLTUZ4MF7ANCNFSM5NFQIYZA . You are receiving this because you commented.Message ID: @.***>

RobertCharles1988 avatar Feb 07 '22 01:02 RobertCharles1988

In the main list, I believe there should be no "Contributing" section at the bottom of the readme.

janpeuker avatar Feb 07 '22 11:02 janpeuker

Contributing

Thank you for pointing. Done πŸ‘πŸΌ

ehsanghaffar avatar Feb 07 '22 12:02 ehsanghaffar

@ehsanghaffarii don't forget to review Pr of others ! Mine is waiting some review : https://github.com/sindresorhus/awesome/pull/2161

riderx avatar Feb 22 '22 14:02 riderx

And the magic word :)

riderx avatar Feb 22 '22 14:02 riderx

It is a good source, practical and rich in content - https://github.com/sindresorhus/awesome/pull/2161#issuecomment-1053606902

This does not count as a review comment. Review comments are supposed to comment on how the list should improve.

sindresorhus avatar Mar 02 '22 08:03 sindresorhus

Hi,

Thank you @ehsanghaffarii for awesome-clubhouse. Please find my review.

CH Bio Generator - CH bio generator is a must-have app for those who are actively using Clubhouse and want to increase their followers on Clubhouse.

It may be better to use "CH Bio Generator" (notice the casing) to indicate the tool in the sentence. It seems you have used this casing in different items. So it would also be more consistent.

Border of Clubhouse - Border for Clubhouse: Clubring is a mobile app that, just as the name says, allows you to create and save various rings around your profile photo.

I think this needs some rewording. It would be simpler to just say maybe, "A mobile app that allows you to create and save various rings around your profile photo."

API Collection - Insomnia API collection.

Question. Is this Clubhouse collection API in Insomnia format? Better description would be good here.

Python API - Clubhouse cli API create with Python.

CLI*, created*/written in Python*

Open Clubhouse - A third-part web application based on flask to play Clubhouse audio.

I think you meant "third-party" here. I would also change casing to "Flask".

AnyHouse - AnyHouse，A Chines client of clubhouse.

Rewriting may be needed. Maybe say just "A Chines client of Clubhouse"?

Programming Python - Coding and programming enthusiasts, Feel free to start rooms! Open to all levels! Suggest your friends as members! JavaScript - JavaScript is the everywhere language; one of the most popular programming languages in the world. Persian Developers Hub - A community of developers who share their knowledge and experience in the field of web development. Programmers - Persian Developers club.

The last two items are descriptive enough. I am not so sure about the first two items. They are more slogan like. However, they are self-evident though; it is about Python programming language club. It would be nice if these two items were more like the others.

Human Behaviour - This club is for everyone interested in - neuroscience/ decision-making, health/ wellness, tech/ computer science, marketing/ influence, start-ups/ VC.

I understood the description is from the link. But, could it be better if we drop slash and just use comma?

eozer avatar Mar 10 '22 17:03 eozer

Hi,

Thank you @ehsanghaffarii for awesome-clubhouse. Please find my review.

CH Bio Generator - CH bio generator is a must-have app for those who are actively using Clubhouse and want to increase their followers on Clubhouse.

It may be better to use "CH Bio Generator" (notice the casing) to indicate the tool in the sentence. It seems you have used this casing in different items. So it would also be more consistent.

Border of Clubhouse - Border for Clubhouse: Clubring is a mobile app that, just as the name says, allows you to create and save various rings around your profile photo.

I think this needs some rewording. It would be simpler to just say maybe, "A mobile app that allows you to create and save various rings around your profile photo."

API Collection - Insomnia API collection.

Question. Is this Clubhouse collection API in Insomnia format? Better description would be good here.

Python API - Clubhouse cli API create with Python.

CLI*, created*/written in Python*

Open Clubhouse - A third-part web application based on flask to play Clubhouse audio.

I think you meant "third-party" here. I would also change casing to "Flask".

AnyHouse - AnyHouse，A Chines client of clubhouse.

Rewriting may be needed. Maybe say just "A Chines client of Clubhouse"?

Programming Python - Coding and programming enthusiasts, Feel free to start rooms! Open to all levels! Suggest your friends as members! JavaScript - JavaScript is the everywhere language; one of the most popular programming languages in the world. Persian Developers Hub - A community of developers who share their knowledge and experience in the field of web development. Programmers - Persian Developers club.

The last two items are descriptive enough. I am not so sure about the first two items. They are more slogan like. However, they are self-evident though; it is about Python programming language club. It would be nice if these two items were more like the others.

Human Behaviour - This club is for everyone interested in - neuroscience/ decision-making, health/ wellness, tech/ computer science, marketing/ influence, start-ups/ VC.

I understood the description is from the link. But, could it be better if we drop slash and just use comma?

Hi, Thanks a lot for the review. I tried to follow your recommendations and add better explanations for the links. I hope it is efficient.

ehsanghaffar avatar Mar 11 '22 03:03 ehsanghaffar

Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

For example, ElectronJS is incorrect.

sindresorhus avatar Jun 02 '22 14:06 sindresorhus

Item descriptions should not be title-cased.

sindresorhus avatar Jun 02 '22 14:06 sindresorhus

You should not commit this: https://github.com/ehsanghaffarii/awesome-clubhouse/blob/main/.DS_Store

sindresorhus avatar Jun 02 '22 14:06 sindresorhus

Thank you for this amazing brief description, amazing and informative. Thanks for making an Awesome list! πŸ™ŒπŸ»

ParsaDj avatar Aug 25 '22 07:08 ParsaDj

Hi @ehsanghaffar,

The list is clear and useful! Here are some of the points that maybe can help you:

  • awesome-lint check a lint error : List item description must end with proper punctuation.

❌ The description of Clubhouse Desktop lost a . .

0Lola avatar Aug 29 '22 06:08 0Lola

Hi @ehsanghaffar,

The list is clear and useful! Here are some of the points that maybe can help you:

  • awesome-lint check a lint error : List item description must end with proper punctuation.

❌ The description of Clubhouse Desktop lost a . .

Thanks for the review, it's ok now

ehsanghaffar avatar Aug 30 '22 00:08 ehsanghaffar