mustermann icon indicating copy to clipboard operation
mustermann copied to clipboard

Expand hash and array

Open tobidelius opened this issue 7 years ago • 4 comments

I don't know if this is a bug or just not supported but I tried this eariler:

pattern = Mustermann.new("/books/:id")
pattern.expand(:append, id: 5, include: ["foo"])
Expected: # => "/books/5?include[]=foo"
Actual: # => "/books/5?include=foo"

What do you guys say?

tobidelius avatar Apr 05 '17 19:04 tobidelius

ping

tobidelius avatar Jun 19 '17 11:06 tobidelius

@sandelius I'm sorry for the late reply. I've been so busy recently. However, this feature looks reasonable for me. If you can dig up into this problem, please write a patch or expected spec. I will seriously face this problem whenever I can spare time

namusyaka avatar Aug 12 '17 20:08 namusyaka

To be honest, I'm not sure :( but at this point any behavior change we should treat with caution

zzak avatar Aug 26 '17 07:08 zzak

@zzak That's why I proposed it before 1.0 ^^ :)

tobidelius avatar Aug 27 '17 07:08 tobidelius