arabic-letter-connector icon indicating copy to clipboard operation
arabic-letter-connector copied to clipboard

Published 20 hours ago • verified publisher icon sinantaifour

Doesn't work with diacritics

Open 0xAli opened this issue 9 years ago • 3 comments

If a word contains diacritics (Tashkeel) it won't be handled properly.

PS: This gem is a life saver.

0xAli avatar Dec 16 '14 06:12 0xAli

Thanks @0xAli! I'd be happy to accept a pull request for this.

sinantaifour avatar Dec 16 '14 11:12 sinantaifour

Awesome gem, thanks!

Excuse my ignorance, but a couple questions on this issue:

  • How feasible would it be to support diacritics in this gem?
  • Without this, will the resulting string by illegible/wrong, or just sub-optimal/harder to read?

mkdynamic avatar Jan 25 '15 02:01 mkdynamic

Hello!

  1. I plan to figure it out later i will (hopefully some day) pull it off, but my guess it's a matter of figuring out the values on a byte level and adding them in "charinfos"

  2. Without that support it will split the word https://i.imgur.com/fhdBuPH.png

I discovered this by accident while working on a project that had only one word with diacritics.

0xAli avatar Jan 25 '15 04:01 0xAli